Small code simplification #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzvals/nzwhich work on any SparseArray derivative (i.e. COO_SparseArray and SVT_SparseArray objects). They even work on dgCMatrix objects and other sparse representations from the Matrix package. Furthermore, nzdata() and nzcoo() are just accessors for the 'nzdata' and 'nzcoo' slots of a COO_SparseArray object, but these slots are not guaranteed to contain the nonzero values and their index in an order that is consistent with the "first dimension is the fastest moving dimension" convention. OTOH nzvals/nzwhich are guaranteed to return the nonzero values and their index in an order that follows this convention. Just a FYI as I don't know if this is relevant in the context of the write_block() method for TileDBRealizationSink objects.
Owner
|
LGTM thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nzvals/nzwhichwork on any SparseArray derivative (i.e. COO_SparseArray and SVT_SparseArray objects). They even work on dgCMatrix objects and other sparse representations from the Matrix package.Furthermore,
nzdata()andnzcoo()are just accessors for thenzdataandnzcooslots of a COO_SparseArray object, but these slots are not guaranteed to contain the nonzero values and their index in an order that is consistent with the "first dimension is the fastest moving dimension" convention. OTOHnzvals()andnzwhich()are guaranteed to return the nonzero values and their index in an order that follows this convention. Just a FYI as I don't know if this is relevant in the context of thewrite_block()method for TileDBRealizationSink objects.