Remove reference to deprecated "startTomcat" gradle task #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbimber
approved these changes
Aug 13, 2025
labkey-susanh
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The existing code customizes ":testAutomation:startTomcat" to append an extra property to the server's
application.properties."stopTomcat" is going away. Instead of updating this to reference "startLabKey", I'm updating it to match the similar code in the premium module. Instead of using
doFirstto update application.properties before starting tomcat, it usesdoLastto update it afterpickPg/pickMssql.createPipelineConfigTask.mustRunAfter tasks.withType(DoThenSetup)is leftover from how that file was handled when running standalone Tomcat. It should be safe to remove.Related Pull Requests
Changes