Skip to content

Add sleep for rendering before clicking variants #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbimber merged 11 commits into from
Oct 27, 2025
Merged

Add sleep for rendering before clicking variants #395

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
58868a9
Add sleep for rendering before clicking variants
bbimber Oct 24, 2025
cf32662
Update click action to click and hold on element
bbimber Oct 24, 2025
cca7d47
Add sleep before clicking variant in JBrowseTest
bbimber Oct 26, 2025
49c09ad
Add WebDriverWrapper import to JBrowseTest
bbimber Oct 26, 2025
2cc0240
Enhance JBrowseTest to wait for variant loading
bbimber Oct 26, 2025
391f7f7
Refactor JBrowseTest to streamline variant handling
bbimber Oct 26, 2025
d0db6a2
Refactor click action to use specific WebElement
bbimber Oct 26, 2025
a6d8dfb
Refactor click action to include pause before click
bbimber Oct 27, 2025
057bebe
Improve element wait handling in JBrowseTestHelper
bbimber Oct 27, 2025
331b42d
Update JBrowseTestHelper.java
bbimber Oct 27, 2025
70a7a9a
Remove unused import for ExpectedConditions
bbimber Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions jbrowse/test/src/org/labkey/test/tests/external/labModules/JBrowseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,9 +450,16 @@ private void testTitleMapping()
beginAt("/" + getProjectName() + "/jbrowse-jbrowse.view?session=mgap&location=1:104..275");
waitForJBrowseToLoad();

// This will wait for them, allowing the full browser to lod:
getVariantWithinTrack("mgap_hg38", "SNV C -> T");
getVariantWithinTrack("mgap_hg38", "SNV G -> C");

Actions actions = new Actions(getDriver());
WebElement toClick = getDriver().findElements(getVariantWithinTrack("mgap_hg38", "SNV T -> C")).stream().filter(WebElement::isDisplayed).collect(JBrowseTestHelper.toSingleton()); // 1:137..137
actions.click(toClick).perform();
actions.moveToElement(toClick)
.pause(500)
.click()
.perform();
waitForElement(Locator.tagWithText("div", "1:137"));
assertElementPresent(Locator.tagWithText("td", "Minor Allele Frequency"));
}
Expand Down Expand Up @@ -1811,4 +1818,4 @@ private void testLuceneColumnSerialization(String sessionId) {
Assert.assertEquals(colVisModelString, getUrlParam("colVisModel"));
testLuceneColumnSerializationFirstRow();
}
}
}