Skip to content

Conversation

@labkey-adam
Copy link

@labkey-adam labkey-adam commented Aug 7, 2025

Rationale

Fix query validation during folder import in ONPRC tests. "Date" is no longer a column in audit event tables.

Related Pull Requests

Copy link

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For user-defined queries, should we also make these audit log tables backwards compatible with Date? It could be handled in DefaultAuditTypeTable.resolveColumn()

@labkey-adam
Copy link
Author

For user-defined queries, should we also make these audit log tables backwards compatible with Date? It could be handled in DefaultAuditTypeTable.resolveColumn()

I was hoping to simplify and get rid of all the legacy names, but yeah, it looks like there are a lot of queries selecting "Date".

@bbimber
Copy link
Collaborator

bbimber commented Aug 7, 2025

For user-defined queries, should we also make these audit log tables backwards compatible with Date? It could be handled in DefaultAuditTypeTable.resolveColumn()

I was hoping to simplify and get rid of all the legacy names, but yeah, it looks like there are a lot of queries selecting "Date".

I did a quick search and outside of the ones covered here, I did not see anything obvious in any of the BimberLab modules. EHR has one (which you might have already seen in a different PR).

If you do go with Josh's option, could that code easily log an error/warning to the server log, notifying TeamCity and/or admins to change it? I'm not sure if this is really required after this PR though.

@labkey-adam
Copy link
Author

For user-defined queries, should we also make these audit log tables backwards compatible with Date? It could be handled in DefaultAuditTypeTable.resolveColumn()

I was hoping to simplify and get rid of all the legacy names, but yeah, it looks like there are a lot of queries selecting "Date".

I did a quick search and outside of the ones covered here, I did not see anything obvious in any of the BimberLab modules. EHR has one (which you might have already seen in a different PR).

If you do go with Josh's option, could that code easily log an error/warning to the server log, notifying TeamCity and/or admins to change it? I'm not sure if this is really required after this PR though.

Thanks for looking... I do have a fix for ehr/DemographicsDeleted.sql: LabKey/ehrModules#1005. Unnecessary after adding a legacy alias for "Date", but it's done.

I'm planning to leave that "Date" alias in place "forever", so I don't think we need to warn.

@labkey-adam labkey-adam merged commit 9053f0d into develop Aug 7, 2025
9 of 11 checks passed
@labkey-adam labkey-adam deleted the fb_demographics_deleted branch August 7, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants