Skip to content

Issue 53225: Unable to delete row from ehr_lookups.procedures #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-bpatel merged 2 commits into from
Sep 2, 2025
Merged

Issue 53225: Unable to delete row from ehr_lookups.procedures #259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9085e79
Log an error instead of throwing an IllegalArgumentException (since i…
labkey-bpatel Aug 20, 2025
d62aff8
Add error log.
labkey-bpatel Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions LDK/src/org/labkey/ldk/query/LookupValidationHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,33 +193,43 @@ public void cascadeUpdate(String targetSchema, String targetTable, String target
qus.updateRows(_user, _container, toUpdate, oldPKs, null, new HashMap<>());
}

public boolean verifyNotUsed(String targetSchema, String targetTable, String targetField, Object val) throws SQLException
public boolean verifyNotUsed(String targetSchema, String targetTable, String targetField, Object val, String triggerScriptName) throws SQLException
{
return verifyNotUsed(targetSchema, targetTable, targetField, val, null);
return verifyNotUsed(targetSchema, targetTable, targetField, val, null, triggerScriptName);
}

public boolean verifyNotUsed(String targetSchema, String targetTable, String targetField, Object val, @Nullable String containerPath) throws SQLException
public boolean verifyNotUsed(String targetSchema, String targetTable, String targetField, Object val, @Nullable String containerPath, String triggerScriptName) throws SQLException
{
Container c = _container;
if (containerPath != null)
{
c = ContainerManager.getForPath(containerPath);
if (c == null)
{
throw new IllegalArgumentException("Unknown container: " + containerPath);
_log.error("Error running '" + triggerScriptName + "' trigger script. Container '{}' not found", containerPath);
return false;
}
}

UserSchema us = QueryService.get().getUserSchema(_user, c, targetSchema);
if (us == null)
throw new IllegalArgumentException("Unknown schema: " + targetSchema);
{
_log.error("Error running '" + triggerScriptName + "' trigger script. Schema '{}' not found in container '{}'", targetSchema, c.getName());
return false;
}

TableInfo ti = us.getTable(targetTable);
if (ti == null)
throw new IllegalArgumentException("Unknown table: " + targetTable);
{
_log.error("Error running '" + triggerScriptName + "' trigger script. Table '{}' not found in container '{}'", targetTable, c.getName());
return false;
}

if (ti.getColumn(targetField) == null)
throw new IllegalArgumentException("Unknown column: " + targetField + " in table: " + targetTable);
{
_log.error("Error running '" + triggerScriptName + "' trigger script. Column '{}' not found in table '{}'", targetField, targetTable);
return false;
}

TableSelector ts = new TableSelector(ti, new SimpleFilter(FieldKey.fromString(targetField), val), null);

Expand Down