Use EHR Study Container Entity Id instead of Study Entity Id to generate cache key #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when trying to populate lookup but goes through this code path when using registering and unregistering lookups trigger script).
bbimber
approved these changes
Sep 1, 2025
Collaborator
bbimber
left a comment
bbimber
left a comment
There was a problem hiding this comment.
i cant think of any reason this would be a problem, but I didnt do any testing.
labkey-martyp
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Generating a cache key with the Study Entity Id requires the Study to be loaded. This becomes an issue when populating lookups - ex. for ehr_lookups.procedures, we want to allow procedures trigger to be registered and unregistered (as done in the related PR), which hits the code path addressed in this PR. In tests, lookups are populated before the Study is created, so the Study Entity Id isn't always available at that point - this causes test failures for the clients that populate ehr_lookups.procedures.
Related Pull Requests
Changes