Gradle 9 and configuration cache compatibility work #225
Conversation
…eprecated `fileCollection` method
| finally | ||
| { | ||
| if (writer != null) | ||
| writer.close() |
There was a problem hiding this comment.
Just curious: does Groovy have try-with-resources?
There was a problem hiding this comment.
Last time I tried, it did not, but I can try again.
There was a problem hiding this comment.
I don't really care, it just seems funny to see this pattern these days
There was a problem hiding this comment.
Seems like it is now supported. (The lag in language support is certainly one of the reasons I regret having chosen Groovy in the first place. Someday maybe we can make the switch to Java (which Gradle itself did a long time ago).)
There was a problem hiding this comment.
I would certainly support that change! Could a Groovy --> Java migration happen incrementally? Or is it all or nothing?
There was a problem hiding this comment.
Pretty sure it's all or nothing, but I've not tried. IntelliJ offers an option to do the work for us, but not sure how well this works. Still, it's very tempting.
Rationale
The
stageModulestask has been using a deprecated method for collecting the modules to be staged. This method is scheduled for removal in Gradle 9.0, so the main goal of this PR is to update that method to remove the use of said method.I've also taken this opportunity to update more of the tasks to be compatible with the configuration cache and remove one task that is no longer very useful and not compatible with the cache.
Related Pull Requests
Changes
checkModuleTaskstasks, added to get us through a transition from plugins being declared more centrallystageModulesto remove use of deprecatedfileCollectionmethod and make compatible with configuration cacheStagingExtensionjsp2Javacompatible with configuration cachecopyExternalLibstask as not compatible with configuration cache for nowServerSideJStask for configuration cache compatibilityDeployAppand relatives for better configuration cache compatibilityPickDbtask for better configuration cache compatibility