Create QC annotation directly from plots #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Dec 18, 2025
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
Pending updates to address manual test results.
| }; | ||
|
|
||
|
|
||
| let nonAnnotationGroups = this.getSvgElForPlot(plot).selectAll("g.non-annotation-group").data(nonAnnotationsData) |
Contributor
There was a problem hiding this comment.
I understand non-annotation as a variable name for the dates without annotations, but it seems less descriptive when it comes to the UI elements. Consider add-annotation or similar since that's what the UI element is used for.
|
|
||
| // Click the add annotation button | ||
| click(addAnnotationButton); | ||
| waitForElement(Locator.xpath("//div[contains(@class, 'x4-window')]//span[text()='Add Annotation']")); |
Contributor
There was a problem hiding this comment.
Look at using org.labkey.test.components.ext4.Window and its WindowFinder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/kanban/issues/1451
Related Pull Requests
Changes