Skip to content

Conversation

@liambrady
Copy link
Contributor

Configure loopback addresses through the ip and ipv6 node config. Loopbacks are automatically configured by networks-autonumber.

Note that loopbacks were always configurable but were for some reason not present within the munet configuration model. This has been fixed.

closes #48

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.41%. Comparing base (20b4816) to head (cbde8c3).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
munet/native.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   58.88%   59.41%   +0.52%     
==========================================
  Files          19       19              
  Lines        5833     5847      +14     
==========================================
+ Hits         3435     3474      +39     
+ Misses       2398     2373      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liambrady liambrady force-pushed the liambrady/loopbacks branch from f3500f6 to ecd31e2 Compare October 10, 2025 13:13
@liambrady liambrady requested a review from choppsv1 October 10, 2025 16:17
Copy link
Contributor Author

@liambrady liambrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK until I am able to correct the YANG schema to account for setting multiple loopback addresses.
Fixed

@liambrady liambrady force-pushed the liambrady/loopbacks branch 3 times, most recently from ffb5ef6 to e9eba78 Compare October 23, 2025 16:26
Configure loopback addresses through the `ip` and `ipv6` node config.
Loopbacks are automatically configured by `networks-autonumber`.

Signed-off-by: Liam Brady <lbrady@labn.net>
Copy link
Collaborator

@choppsv1 choppsv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@choppsv1 choppsv1 merged commit c53c72a into LabNConsulting:main Jan 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loopback addresses

2 participants