Skip to content

Conversation

@liambrady
Copy link
Contributor

Increase the console timeout values of multiple tests. This prevents premature failures from being thrown within the github CI.

Note: I ran the github CI ~8 times on my munet fork with no recorded timeout-related issues.

@liambrady liambrady requested a review from choppsv1 October 23, 2025 17:37
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.19%. Comparing base (20b4816) to head (e4383c4).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   58.88%   59.19%   +0.30%     
==========================================
  Files          19       19              
  Lines        5833     5833              
==========================================
+ Hits         3435     3453      +18     
+ Misses       2398     2380      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# user: "root"
# password: "foobar"
# timeout: 3600
timeout: 3600
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the current default 60 seconds? When you need the larger value what is the actual time that is taken?

It seems this test was mostly passing before so maybe we can increase the value more conservatively, even 10 times longer is 600 (i.e., 10 minutes), going from 1 minute to 1 hour seems like a pretty huge leap :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more conservative increase should be fine. The current default ended up being more or less was equal to the actual startup time (hence the observed failures when it took a little longer than usual).

Sets the console timeout values of multiple tests as 600 sec. This
prevents premature failures from being thrown within the github CI.

Signed-off-by: Liam Brady <lbrady@labn.net>
@liambrady liambrady force-pushed the liambrady/qemu_ci_timeout branch from f36d537 to e4383c4 Compare January 2, 2026 14:12
@liambrady liambrady requested a review from choppsv1 January 2, 2026 14:14
@choppsv1 choppsv1 merged commit 82a7345 into LabNConsulting:main Jan 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants