Make edit_message_text return ApiError::MessageNotModified
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editing message text to the same value is an easy mistake to make, so I would like to test my code against it. I would also like to receive the error properly as an ApiError enum variant, so this commit introduces a way for teloxide_tests actions to return standard error values of Telegram Bot API that teloxide can actually parse. In the future, other usages of check_if_message_exists and ErrorBadRequest should also be replaced with ApiErrors where possible.
IlyaBizyaev
force-pushed
the
feat/canonical-errors
branch
from
ca963d7 to
4c4f82e
Compare
LasterAlex
approved these changes
Mar 1, 2025
Owner
LasterAlex
left a comment
LasterAlex
left a comment
There was a problem hiding this comment.
Ok, that is very useful! In the ideal world all of the error messages should be refactored for this, but it's a good start
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editing message text to the same value is an easy mistake to make, so I would like to test my code against it.
I would also like to receive the error properly as an
ApiErrorenum variant, so this commit introduces a way for teloxide_tests actions to return standard error values of Telegram Bot API that teloxide can actually parse.In the future, other usages of
check_if_message_existsandErrorBadRequestshould also be replaced withApiErrors where possible.