-
Notifications
You must be signed in to change notification settings - Fork 7
Fixes for class 1 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note all interactive elements are broken in the HTML preview. I think the recent BonitoBook.jl (tries to?) fix this (though it seems you would have to write JS code which.. is probably not worth it) |
is this a problem? |
|
CI took almost an hour! Is that expected? |
Not a problem. its just that Documenter expects there to be a package but this repo is not structred as a package. |
Not expected. It takes somewhere between 3 to 13 minutes for me (see https://github.com/LearningToOptimize/LearningToControlClass/actions/runs/16893071727). Perhaps it is the CI documenter verion change? |
Ah yeah probably due to the 1.10.6 pin I tried to get rid of the warning. Trying out just removing the manifest file now, do you think it's important to commit them? |
I want to avoid any students having problems with versions, and this is the usual way people prepare workshops. Nevertheless, I am thinking that we can probably just make each person compile their own pluto when submitting a class. This way we the manifests and project tomls of each class won't influence the documenter anymore. |
andrewrosemberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
WIP