Gbl.master #18
Open
Gbl.master #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2014 11:35
…ill convert REMOTE_USER to lower/uppercase. Any other string, as well as not setting the option, will leave REMOTE_USER alone.
…pendent of LogLevel, which produces a lot of spam in error_log. Changed Log Level APLOG_NOTICE to APLOG_INFO to prevent this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NTLM on Firefox will convert all usernames to uppercase. This might cause confusion when you're upgrading from basic Auth to NTLM and have lowercase usernames in your database. This adds an option NameCase which you can set to 'lower' or 'upper', which enforces lowercase/uppercase in REMOTE_USER. Omitting this option makes PyAuthenNTLM2 behave like it does now.
Also, at least some versions of Apache will always log AP_NOTICE, independent of Log Level, which causes a lot of spam in error_log. This version fixes that by using AP_INFO instead of AP_NOTICE.