-
Notifications
You must be signed in to change notification settings - Fork 3
feat: ✨ Joystick enhancements #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add an abstarct DriveCurve class and a concrete ExproDriveCurve class, both based on LemLib's implementation.
Allow users to assign a DriveCurve per axis to be used by the controller when updating joystick values.
…/joystick-enhancements
SizzinSeal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from a design standpoint, but it needs more docs as well as some other nitpickings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (almost), just need to wrap up our convo on function defs in headers vs in source, and fix style issues
|
Test data: |
(Note: Fisheye is still broken)
|
More tests: |
Add controller deadband, curves and fisheye, also changes the const references to Button/floats into getter methods, and renames some stuff.
Test code:
Download the template for this pull request:
Note
This is auto generated from
Add Template to Pull Request