Improve stitching efficiency and UI adjustments

[Lortunate]

• Optimization: Enhanced overlap detection, motion masking, and seam finding in the stitching module to improve efficiency and accuracy.
• Style Update: Removed borders from the long capture preview window for a cleaner UI.
• Bug Fix: Resolved an issue where tooltips occluded buttons in the long capture toolbar.

No additional changes or dependencies introduced.

[gemini-code-assist]

Summary of Changes

Hello @Lortunate, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers substantial improvements to the long capture feature by overhauling its underlying image stitching algorithm. The changes aim to make the stitching process faster, more robust, and capable of handling various scrolling scenarios, including reverse scrolling. Concurrently, the user interface for the long capture preview has been streamlined by removing unnecessary borders, and a bug preventing proper interaction with toolbar buttons due to tooltip interference has been resolved.

Highlights

• Stitching Algorithm Refinement: The core image stitching logic has been significantly re-engineered for improved efficiency and accuracy, incorporating motion masking, signature-based overlap detection, and smart seam finding.
• UI Border Removal: The long capture preview window now has a cleaner aesthetic due to the removal of its borders.
• Tooltip Occlusion Fix: Tooltips in the long capture toolbar no longer obstruct buttons, enhancing usability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces significant improvements to the image stitching functionality, along with some UI adjustments. The stitching algorithm in stitcher.rs has been completely rewritten to be more efficient and robust, now including motion masking, reverse scroll detection, and smarter seam finding. The changes are extensive and well-structured. My review focuses on the new Rust implementation, where I've identified a couple of minor areas for improvement to increase accuracy. The QML changes for the UI are clean, effectively addressing the border removal and tooltip issue as described.

[Lortunate]

/gemini review

[gemini-code-assist]

Code Review

This pull request brings a mix of UI refinements and significant performance improvements to the image stitching logic. The UI changes, such as removing borders and adjusting component styles, contribute to a cleaner look. The fix for tooltips occluding buttons is well-implemented by adding a property to control their visibility. The core of this PR is the refactoring of the ScrollStitcher, which introduces a more sophisticated algorithm involving motion masking, reverse scroll detection, and smarter seam finding. This is a great enhancement. My review focuses on improving the maintainability of this new logic by addressing hardcoded 'magic numbers' and clarifying the configuration. I've also noted a minor inconsistency in the QML theme usage and a point about Rust API design.

[gemini-code-assist]

Code Review

This pull request significantly improves the stitching efficiency and accuracy of the capture module through enhanced overlap detection, motion masking, and seam finding. The UI has also been refined by removing borders from the long capture preview window and resolving an issue where tooltips occluded buttons in the long capture toolbar. The changes are well-aligned with the stated objectives.

[Lortunate]

/gemini review

[gemini-code-assist]

Code Review

This pull request delivers significant improvements to the image stitching functionality and enhances the user interface. The core stitching algorithm has been impressively rewritten for better efficiency and accuracy, incorporating advanced techniques like motion masking and bidirectional scroll detection. The code is now more modular and easier to understand. Additionally, the UI has been polished by removing borders from the preview window and resolving a tooltip occlusion bug with a clean and effective solution. Overall, this is an excellent update. I have a few minor suggestions to further improve code clarity and safety.