Misc DX improvements for contributors #574
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It minimizes the amount of crates to be rebuilt, thus maximising local iteration speed.
LukeMathWalker
force-pushed
the
speed-up-tests
branch
from
4fa4321 to
e9abd86
Compare
LukeMathWalker
force-pushed
the
speed-up-tests
branch
3 times, most recently
from
36549cc to
0bc1f2a
Compare
LukeMathWalker
force-pushed
the
speed-up-tests
branch
from
0bc1f2a to
f6ba604
Compare
When generating the JSON docs for a batch of crates, we index the item in each crate in parallel using rayon rather than one-by-one.
LukeMathWalker
force-pushed
the
speed-up-tests
branch
from
60f92ed to
3c1cc63
Compare
Build it once, rather than (re)building and filtering it down every single time we compute the cache key for a third-party crate.
Insertion happens on the "main" thread, but the more expensive format conversion is executed on a threadpool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.