-
Notifications
You must be signed in to change notification settings - Fork 36
Switch to Wwiser.NET implementation for all Wwise bank parsing #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
henbagle
wants to merge
22
commits into
Beta
Choose a base branch
from
WwiserMerge
base: Beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Wwiser.NET ObjectBinary subclass for WwiseBanks\nMove Soundplorer into new namespace, break HIRC hex editor into it's own UserControl\nPort soundplorer mostly to Wwiser.NET backing types, breaking many things\nPort some other small functions to use Wwiser.NET types
We don't need to parse arbitrary floats or ids, or guess anything now that the whole binary is parseable
Member
Author
|
Tests are gonna fail for a while because I don't have the Init bank reserializing properly in Wwiser.NET |
…alization of missing banks
Add experiment to dump all WwiseBanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of existing WwiseBank ObjectBinary implementation, new ObjectBinary is a wrapper around Wwiser.NET. Everywhere that ObjectBinary has been used has been converted to use the Wwiser.NET types.
WwiseGraphEditor Changes:
Soundpanel changes
BinaryInterpreter Changes:
I think there was some more I was going to update with HIRC editing here but I have since forgotten.
Fix #437, fix #438