Make weather API easier to use; tidy test organization a little #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-ross
force-pushed
the
tidy-weather-api
branch
from
0ff1907 to
205ab3d
Compare
aditeyashukla
requested changes
Dec 11, 2025
Contributor
aditeyashukla
left a comment
aditeyashukla
left a comment
There was a problem hiding this comment.
Makes total sense and looks good! We just need to update all usage of get_ground_speed in legacy.py re my comment
aditeyashukla
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a couple of things:
Weatherobject for each ground track and mission, aWeatherobject is built by just giving the directory where its input data is stored. TheWeatherobject manages opening the weather data files and slicing them on demand as theget_ground_speedmethod is called.