Fix model iv py halo import #122
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #108
Updates pyHalo imports to use the factory function
preset_model_from_name()for compatibility with newer pyHalo versions while maintaining backward compatibility.Problem
Recent pyHalo versions removed/relocated the
PresetModelsmodule, causing:ModuleNotFoundError: No module named 'pyHalo.PresetModels.cdm'ImportError: cannot import name 'CDM'Solution
Replace direct imports with version-agnostic factory function:
Before:
After:
Changes Made
generate-paired.ipynbsmooth_image_comparison.ipynbTesting
✅ Notebooks execute without import errors
✅ Works with pyHalo >= 1.x (new API)
✅ Falls back gracefully to pyHalo < 1.x (old API)
✅ No functional changes to simulations
Scope
🔹 Only import statements modified
🔹 No dependency version changes
🔹 No numerical/functional behavior altered