Add delete and archive buttons in messages #1996
Conversation
5aola
changed the title
templates/messages/message.html
Outdated
| href="" | ||
| data-action-value="a"> | ||
| {% if message.is_archived %}{% bw_icon "box-remove" %}{% else %}{% bw_icon "box-add" %}{% endif %} | ||
| </i>{% if message.is_archived %}Unarchive{% else %}Archive{% endif %}</a>{% endif %} |
There was a problem hiding this comment.
Closing tag </i> matches nothing
templates/messages/message.html
Outdated
| class="h-spacing-left-2 btn-inverse no-hover message-action" | ||
| href="" | ||
| data-action-value="dm"> | ||
| {% bw_icon "trash" %}</i>Delete</a> |
There was a problem hiding this comment.
Closing tag </i> matches nothing
There was a problem hiding this comment.
This change is a bit hacky and it took me a while to understand why this works.
Maybe it's better to add a form to templates/messages/message.html?
templates/messages/message.html
Outdated
| </div> | ||
| <div class="col-12"> | ||
| <div class="v-spacing-top-5 text-center"> | ||
| <div class="v-spacing-top-5 text-center" data-message-id="{{ message.id }}"> |
templates/messages/message.html
Outdated
| {% endblock %} | ||
|
|
||
| {% block extrabody %} | ||
| <script src="{% static 'bw-frontend/dist/messages.js' %}"></script> |
There was a problem hiding this comment.
I think we should not rely on messages.js here.
A simple form / POST --> to messages-change-state might be cleaner.
See comment above (line 51)
|
Thanks for the feedback. My initial thinking was just to recreate a very similar behavior to the other delete and archive buttons at display_message.html, but it makes sense to just use forms POST call to trigger the original |
2 participants
Issue(s)
#172
Description
Added buttons to delete and archive the message when it's in detailed view.
The features of the buttons are kept original. If the message is deleted, it redirects to the messages list page.