When removing a category, delete bookmarks which would become a conflict #2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a unique constraint on (user, sound_id) when category is null. When we delete a category we keep the bookmarks but remove the category. If there is already a bookmark for this sound with no category then we get a unique constraint error when trying to set a category to null. Delete any bookmarks from this category that would cause a problem before deleting the category.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a unique constraint on (user, sound_id) when category is null. When we delete a category we keep the bookmarks but remove the category. If there is already a bookmark for this sound with no category then we get a unique constraint error when trying to set a category to null. Delete any bookmarks from this category that would cause a problem before deleting the category.
Issue(s)
Fixes https://logserver.mtg.upf.edu/organizations/sentry/issues/4724