handle search query processor errors in map browse page #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an sqp has an error (e.g. invalid grouping_pack filter is set) then return an error instead of trying to render the map
We rewrite a filter of the form "duration:[lower TO upper]", but we get some queries of "duration:lower TO upper" which parses as a string not a range. In this case, skip the conversion and omit the parameter.
alastair
force-pushed
the
browse-nonetype
branch
from
c36c14a to
91e8c27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
Fixes https://logserver.mtg.upf.edu/organizations/sentry/issues/3955/
Fixes https://logserver.mtg.upf.edu/organizations/sentry/issues/4730/
Description
We rewrite old query parameters of the form
duration:[1 TO 3]to the new search interface. If the value of duration is invalid (e.g.duration:1 TO 3(no braces) or evenduration:[1 to 3](lower-case to) then the parser treats this as a string not a range. Only convert this parameter if it is valid, otherwise ignore it.In the case that an invalid parameter is passed (
grouping_pack), show an error message on the map page, as we do on the search pageFailing tests are fixed in #2033