Skip to content

Conversation

@rfcbf
Copy link
Contributor

@rfcbf rfcbf commented Dec 30, 2025

Description

Optimizes the feed highlights carousel for better performance by reducing shadow complexity and utilizing drawing groups.

Introduces a vertical carousel layout for landscape mode, providing an alternative display of highlights alongside the main feed.

Enhances accessibility and provides a more refined user experience through adjusted card layouts and auto-scroll improvements.

Type of Change

  • 🎉 feat: New feature
  • 🐛 fix: Bug fix
  • 📝 docs: Documentation update
  • 💄 style: Code style/formatting changes
  • ♻️ refactor: Code refactoring
  • perf: Performance improvement
  • test: Adding or updating tests
  • 🔧 chore: Maintenance tasks
  • 🏗️ build: Build system changes
  • 👷 ci: CI configuration changes

Related Issue

Screenshots/Videos

Testing

  • Tested on iPhone (specify model/iOS version):
  • Tested on iPad (specify model/iOS version):
  • All unit tests pass
  • No SwiftLint warnings/errors

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have updated the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My branch is up-to-date with the base branch

Additional Notes

Optimizes the feed highlights carousel for better performance by reducing shadow complexity and utilizing drawing groups.

Introduces a vertical carousel layout for landscape mode, providing an alternative display of highlights alongside the main feed.

Enhances accessibility and provides a more refined user experience through adjusted card layouts and auto-scroll improvements.
@rfcbf rfcbf closed this Dec 30, 2025
@rfcbf rfcbf changed the title Improves feed highlights carousel performance feat: improves feed highlights carousel performance Dec 30, 2025
@rfcbf rfcbf reopened this Dec 30, 2025
Removes the placeholder implementation for handling highlight taps.
This streamlines the codebase and prepares for the actual implementation.
Moves the highlight index state out of the individual carousel and vertical highlight views, and passes it in as a binding.

This change allows the parent view to control and synchronize the index across both views, ensuring consistent highlight selection between the carousel and vertical list.
@cassio-rossi cassio-rossi merged commit a8a8ec3 into MacMagazine:develop Dec 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants