Skip to content

Conversation

@maryann-macrometa
Copy link
Contributor

Made some edits to EDS, especially the quickstart section. Want to be sure it's right .

@vercel
Copy link

vercel bot commented Jun 5, 2024

@maryann-macrometa is attempting to deploy a commit to the Team Macrometa Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, minor comments are added.

## FaaS v1.001
This represents the very first version of the PhotonIQ Function as a Service(FaaS)
## May 2024 Release
### v1.001
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use semver notation for vesions: https://semver.org/
This needs to be 1.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to use GUI images for docs, and when we need to display terminal output, we can use bash code comments. It is easier for developers to see what is happening, and they can also copy-paste from the docs, for example, the same filter while testing. What is marked on the image my suggestion is to move it to a line text explanation

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant