VWRs edits #1193
Open
VWRs edits #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryann-macrometa
requested review from
a user,
amol-macrometa,
joubert-macrometa,
naimishvora-macrometa and
todor-macrometa
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joubert-macrometa
suggested changes
Jun 11, 2024
|
|
||
| ## The VWR Workflow | ||
|
|
||
| During moments of peak traffic, VWRs makes a new page separate from your origin to organize visitors. The VWRs workflow ensures that users are directed to the appropriate origin service while ensuring fairness in the queue and providing metrics and alerts to the administrator. |
Contributor
There was a problem hiding this comment.
I don't understand "makes a new page". What do you mean?
|
|
||
| During moments of peak traffic, VWRs makes a new page separate from your origin to organize visitors. The VWRs workflow ensures that users are directed to the appropriate origin service while ensuring fairness in the queue and providing metrics and alerts to the administrator. | ||
|
|
||
| 1. The Akamai EdgeWorkers check the virtual room service to confirm if a waiting room is set up for an origin service |
Contributor
There was a problem hiding this comment.
There is only one EdgeWorker. So is "EdgeWorkers" still correct? Below it is singular.
"check the virtual room service"... Do you "check the virtual room service" or "check with the virtual room service"?
Did you mean to call it "virtual room service" and not "virtual waiting room service"?
| - If no waiting room, the EdgeWorker sends the traffic request directly to the origin service. | ||
| - If there is a waiting room, the EdgeWorker sends to the waiting room. | ||
|
|
||
| 3. The waiting room service adds the request to the waiting room associated with the domain. |
Contributor
There was a problem hiding this comment.
I am confused about "domain". Is this the old nomenclature "domain" or is this a different domain?
Contributor
There was a problem hiding this comment.
I think it's okay for this to stay as-is.
docs/photoniq/vwrs/04-queue-types.md
Outdated
|
|
||
| ## FIFO | ||
|
|
||
| This FIFO (first in, first out) queue operates on a "first come, first served" basis. Every new request pushes older requests to the front of the queue, closer to the origin server. Thus, when the system removes a request from the front, all subsequent elements move up one position. |
Contributor
There was a problem hiding this comment.
What is "this" referencing?
|
|
||
| ## Available Metrics | ||
|
|
||
| The metrics response body includes the following properties: |
Contributor
There was a problem hiding this comment.
"response body" ?? I think this is about an REST API, but there was no reference to a REST API.
Contributor
Author
There was a problem hiding this comment.
It's a response to an API call. I'll make it clearer in my next commit
Co-authored-by: Joubert Berger <88400412+joubert-macrometa@users.noreply.github.com>
Co-authored-by: Joubert Berger <88400412+joubert-macrometa@users.noreply.github.com>
Co-authored-by: Joubert Berger <88400412+joubert-macrometa@users.noreply.github.com>
Co-authored-by: Joubert Berger <88400412+joubert-macrometa@users.noreply.github.com>
Implemented some edits
docs/photoniq/vwrs/03-configuration-and-setup/02-configure-waiting-rooms.md
Outdated
Show resolved
Hide resolved
docs/photoniq/vwrs/03-configuration-and-setup/04-customizing-vwrs.md
Outdated
Show resolved
Hide resolved
docs/photoniq/vwrs/03-configuration-and-setup/01-configuring-edgeworkers.md
Show resolved
Hide resolved
todor-macrometa
suggested changes
Jun 11, 2024
…ting-rooms.md Co-authored-by: Todor <153493191+todor-macrometa@users.noreply.github.com>
…ting-rooms.md Co-authored-by: Joubert Berger <88400412+joubert-macrometa@users.noreply.github.com>
todor-macrometa
suggested changes
Jun 18, 2024
Contributor
todor-macrometa
left a comment
todor-macrometa
left a comment
There was a problem hiding this comment.
See suggestions.
|
|
||
| ```bash | ||
| curl -X 'PATCH' \ | ||
| https://api-vwr-service.gdn-akamai.com/api/vwr/v1/origins/example3.com \ |
Contributor
There was a problem hiding this comment.
Suggested change
| https://api-vwr-service.gdn-akamai.com/api/vwr/v1/origins/example3.com \ | |
| https://api-vwr-service.gdn-akamai.com/api/vwr/v1/waitingrooms/example3.com \ |
|
|
||
| - The waiting room service periodically checks the sessions to remove requests for expired sessions from the queues. | ||
| - The waiting room service collects the metrics for each waiting room. | ||
| - The administrator can turn customer domains on or off through Configuration APIs. |
Contributor
There was a problem hiding this comment.
Suggested change
| - The administrator can turn customer domains on or off through Configuration APIs. | |
| - The administrator can turn customer waiting rooms on or off through Configuration APIs. |
| - If no waiting room, the EdgeWorker sends the traffic request directly to the origin service. | ||
| - If there is a waiting room, the EdgeWorker sends to the waiting room. | ||
|
|
||
| 3. The waiting room service adds the request to the waiting room associated with the domain. |
Contributor
There was a problem hiding this comment.
I think it's okay for this to stay as-is.
Co-authored-by: Todor <153493191+todor-macrometa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the misleading branch name. I made some changes to VWRs.