Skip to content

Conversation

@MarkoMacrometa
Copy link
Contributor

fixing issues with git

@vercel
Copy link

vercel bot commented Feb 1, 2023

@MarkoMacrometa is attempting to deploy a commit to the Team Macrometa Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Feb 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Feb 1, 2023 at 5:36PM (UTC)

Copy link
Contributor

@dustinlarimer dustinlarimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkoMacrometa Nice, should we call this a query performance guide?

@diana-macrometa any thoughts on where this should live? Perhaps within the Queries section?

@diana-macrometa
Copy link
Contributor

Most likely the Queries and Query Workers section, yes, unless this is queries that you use in stream workers as well.

@@ -0,0 +1,166 @@
---
sidebar_position: 50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there multiple sidebar_positions at 50? Please put them in numerical order, preferably using two-digit numbers (10, 20, 30). This makes it easier to deal add files in later.

@diana-macrometa
Copy link
Contributor

Why are these files included in this PR?
image

Copy link
Contributor

@diana-macrometa diana-macrometa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guys, I have the sneaking suspicion that I should give you guys a crash course in Docusaurus and documentation at Macrometa. I can show you guys how to make local builds and a few other things that I think will help you a lot as you work on documentation. Please feel free to throw something on my calendar Thursday or Friday.

In the meantime, please put these topics in order, add headings, apply title case, and review the other comments I have put in so far. Also, please take a close look at the intro paragraphs. We want users to be able to quickly understand what the topic is about, and we also want the words to help guide search results, because users like to do web searches to get answers to their questions.

Great content, I am so excited to work with you guys on this!

@@ -0,0 +1,4 @@
{
"label": "Best Practice",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"label": "Best Practice",
"label": "Best Practices",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these best practices for? Queries? Or a bunch of different things?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of them are for Queries.

@@ -0,0 +1,166 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an index.md file to both folders. This will serve as an introduction. The user will see it when they click the folder in the side menu, so use it to provide context and tell the reader what to expect in this section. It doesn't have to be long.

title: LIMIT and OFFSET vs Cursor API and hasMore
---

Queries that return large volumes of data may require more than one response to provide the complete results. A common method is using the `LIMIT` and `OFFSET` statements in the query. However, this is not the optimized approach. When these options are used, each time the query is invoked query processing is performed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "might" rather than "may" to refer to the possibility that something could happen. "May" suggests permission, as in, "You may submit that PR."


The `batchSize` parameter can be set in the `cursor` API to configure the number of documents returned per request. The `batchSize` default is `100` and the maximum value is `1000`.

**Query with `LIMIT` and `OFFSET`**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use bold in place of headings. The h1 will be set by the topic title, so the next one down in the hierarchy is h2.

# h1
## h2
### h3

@@ -0,0 +1,113 @@
---
sidebar_position: 50
title: Multiple collections vs single large collection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use title case in file names, not sentence case.

Also, this is a long title. How did it look when you built it locally?

}
```

API Reference Docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a heading.

title: Use of indexes for COLLECT operation
---

If there is a `COLLECT` operation in the query, the records with similar attribute values are grouped. Persistent index on the attribute value on which `COLLECT` operation is performed helps to optimize the query. In the following example, the persistent index on the `country` attribute will help to optimize the query.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If there is a `COLLECT` operation in the query, the records with similar attribute values are grouped. Persistent index on the attribute value on which `COLLECT` operation is performed helps to optimize the query. In the following example, the persistent index on the `country` attribute will help to optimize the query.
If there is a `COLLECT` operation in the query, then the records with similar attribute values are grouped. Persistent indexes on the attribute value on which `COLLECT` operation is performed helps to optimize the query. In the following example, the persistent index on the `country` attribute helps to optimize the query.

@@ -0,0 +1,6 @@
---
sidebar_position: 50
title: Use of composite index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this topic so extremely short?

@@ -0,0 +1,4 @@
{
"label": "When indexes will not work?",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean?

@@ -0,0 +1,4 @@
{
"label": "Best Practice",
"position": 125
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are both folders at position 125?

Copy link
Contributor

@dustinlarimer dustinlarimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkoMacrometa Can we move this install_nvm.sh script to a separate PR? I'm all for helpful setup scripts, but I'd like to review and discuss this one separately so it doesn't block the content in this PR.

@james-macrometa
Copy link
Contributor

@diana-macrometa @dustinlarimer I am performing some edits to merge into Marko's branch. They address many of the requests you have made here.

@diana-macrometa
Copy link
Contributor

diana-macrometa commented Feb 6, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants