Source/Sink types - websocket and websocket-server #692
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@diana-macrometa This is close to ready for review, but I'm still fuzzy on how WebSockets work. Setting up a meeting with an SME to chat before I put this into review, but feel free to take a look if you like. |
Co-authored-by: Diana Payton <105658419+diana-macrometa@users.noreply.github.com>
|
|
||
| The [WebSocket sink](websocket.md) sends events through the server which are then passed to the `example` stream. All events received by `example` stream are then sent to the WebSocket server | ||
|
|
||
| Clients can connect to `ws://localhost:9025/abc` to receive events from the stream. |
There was a problem hiding this comment.
@StoyanTc Does the URL have to be this specific value (ws://localhost:9025/abc)? Or do we need to provide more specific instructions for connecting?
Co-authored-by: Diana Payton <105658419+diana-macrometa@users.noreply.github.com>
Co-authored-by: Diana Payton <105658419+diana-macrometa@users.noreply.github.com>
…orp/docs into websocket-source-sink
|
@StoyanTc Can you please take a look at the docs in this PR + the SQL samples and let me know how they look? Thank you! |
StoyanTc
left a comment
StoyanTc
left a comment
There was a problem hiding this comment.
@diana-macrometa - Could we hold off the doc for this extension and get rid of the existing one if there is such for 0.17.12.
Here are the reasons:
- No one has tested it till now I think?
- I believe some of the parameters from the original extension will get taken out but others will be introduced.
|
@StoyanTc, we can hold it until after 17.12 is deployed. WebSocket is one of the source/sinks you told me that we support but lacked documentation for. I was not aware that there would be additional testing needed. What do we need to do for this and the other missing source/sink documentation? |
I told you before that we have such extensions implemented but I have probably forgotten to tell you that no one has tested them. |
|
Not a problem. These things do not have a due date. |
|
@dlozina-macrometa, is this something you might be interested in testing? |
This PR adds Stream Workers related content for WebSocket source/sinks