move default modules from /modules/default to /defaultmodules

[khassel]

Since the project's inception, I've missed a clear separation between default and third-party modules.

This increases complexity within the project (exclude modules, but not modules/default), but the mixed use is particularly problematic in Docker setups.

Therefore, with this pull request, I'm moving the default modules to a different directory.

I've chosen default/modules, but I'm not bothered about it; defaultmodules or something similar would work just as well.

Changed to defaultmodules.

Let me know if there's a majority in favor of this change.

[khassel]

I understand that a few third-party modules would also need to be modified, such as MMM-Config and MMM-RemoteControl.

Perhaps it's also possible to store the new relative path in js/defaults.js so that it can be accessed via the config file.

[KristjanESPERANTO]

I think I'm neutral on this. But if the change happens, I would prefer “defaultmodules” slightly more.

Currently I'm maintaining MMM-RemoteControl, so I could adapt it.

[sdetweil]

I prefer defaultmodules as well

there is nothing else we would put in the default folder, right?

[khassel]

there is nothing else we would put in the default folder, right?

yes, everything which is now under modules/default would move to defaultmodules

[sdetweil]

No. I meant is it conceivable that there are other entities besides modules we would put in a folder called default

I understand the modules
Just trying to think of use cases

css, separating ours from users more
Anything in our 3 runtimes we would separate?
Client, server, combined

[khassel]

yes, the custom.css, at the moment in the css folder which is a folder owned by this repo. I would see custom.css inside config folder. But don't want to do this in this PR ...

Another approach could be to do everything into config folder which is user related:

• config.js
• custom.css
• 3rd-party-modules

The last approach would allow the standard modules to remain in their current location, but I think that would be a massive change for every user, so I immediately dismissed that idea.

[sdetweil]

I have updated MMM-Config to handle either default modules location