Skip to content

Implement convert button functionality and prevent vertical scrolling… #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MahbubHS merged 1 commit into from
Dec 23, 2024
Merged

Implement convert button functionality and prevent vertical scrolling… #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions assets/script/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ const yelem = document.getElementById("y");
const calgroup = document.getElementById("calgroup");
const cal1elem = document.getElementById("cal1");
const cal2elem = document.getElementById("cal2");
const convertBtn = document.getElementById("convertBtn");

window.addEventListener("DOMContentLoaded", function () {
calgroup.style.display = "none";
var params = GetURLParams();
Expand All @@ -14,8 +16,7 @@ window.addEventListener("DOMContentLoaded", function () {
sel2elem.value = params.sel2;
onconvert();
}
const savedTheme = localStorage.getItem("theme") || "light";
document.documentElement.setAttribute("data-theme", savedTheme);
toggleConvertButton();
});

function GetURLParams() {
Expand Down Expand Up @@ -196,13 +197,21 @@ inputTypeSelect.addEventListener("change", () => {
}
});

xelem.addEventListener("input", validateInput);
xelem.addEventListener("input", () => {
validateInput();
toggleConvertButton();
});
sel1elem.addEventListener("change", validateInput);

function onclear() {
xelem.value = "";
yelem.value = "";
calgroup.style.display = "none";
toggleConvertButton();
}

function toggleConvertButton() {
convertBtn.disabled = xelem.value.trim() === "";
}

// Removed theme toggle event listener
2 changes: 1 addition & 1 deletion assets/stylesheet/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ footer a {
flex-direction: column;
justify-content: center;
align-items: center;
overflow: auto;
overflow: hidden; /* Prevent vertical scrolling */
}

.input-error {
Expand Down
3 changes: 2 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,12 @@ <h1 class="text-center">Base Converter</h1>
</div>
<div id="ab" class="form-group md-1 d-flex justify-content-between">
<button
id="br"
id="convertBtn"
type="button"
title="Convert"
class="btn btn-success"
onclick="onconvert()"
disabled
>
<svg
width="20"
Expand Down