feat: Deprecate Shanten.number_characters and Shanten.number_isolated_tiles
#82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the public attributes
Shanten.number_charactersandShanten.number_isolated_tiles.Both attributes were previously exposed as public fields but actually represent internal state used during backtracking.
Accessing them now triggers a DeprecationWarning with the message:
No setter is provided; attempts to assign to these attributes will raise
AttributeError.In addition, following the proposal in
Shanten.number_charactersandShanten.number_isolated_tilesHave Inappropriate Names #57, the internal fields have been renamed to more accurate identifiers (_flag_four_copiesand_flag_isolated_tiles) to avoid confusion with tile categories or counts.Benefits of this change
Shanten.number_charactersandShanten.number_isolated_tilesHave Inappropriate Names #57fix #57