Skip to content

Conversation

@Apricot-S
Copy link
Collaborator

@Apricot-S Apricot-S commented Oct 10, 2025

This PR deprecates all public attributes of Shanten other than AGARI_STATE.

  • These attributes were previously exposed as public fields but actually represent internal state used during backtracking.

  • Accessing them now triggers a DeprecationWarning with the message:

    "`<name>` is deprecated. This attribute reflects internal state and should not be used."

- No setter is provided; attempts to assign to these attributes will raise AttributeError.

Benefits of this change

  • Improves API clarity
  • Prevents misuse of unstable internal values

@Apricot-S Apricot-S force-pushed the feat/shanten-field-2 branch from e7d339b to a4b92df Compare October 11, 2025 08:03
@Apricot-S Apricot-S marked this pull request as ready for review October 11, 2025 08:05
@Apricot-S Apricot-S requested a review from Nihisil October 11, 2025 08:05
Copy link
Contributor

@Nihisil Nihisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Nihisil Nihisil merged commit 14d880f into MahjongRepository:master Oct 11, 2025
10 checks passed
@Apricot-S Apricot-S deleted the feat/shanten-field-2 branch October 11, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants