Skip to content

Conversation

@Simzard10
Copy link
Collaborator

연관 이슈

PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트

작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요

  • 사장/알바생 FAQ 조회 API 개발
  • 사장 구독 현황, 결제 수단 없을 때 null DTO 반환
  • 로그아웃 기능 개발
  • 지각 시 사장에게 알림 기능 추가

리뷰 요구사항 (선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

@Simzard10 Simzard10 requested review from Copilot and hyunzzii June 9, 2025 04:15
@Simzard10 Simzard10 self-assigned this Jun 9, 2025
@Simzard10 Simzard10 added feat 새로운 기능 추가 ci/cd 배포 및 빌드 설정 labels Jun 9, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges development changes into main, introducing FAQ APIs, enhancing subscription and billing flows, adding logout functionality with token blacklisting, and updating CI environment variables.

  • Add repository, service, facade, and controller layers for boss and staff FAQ retrieval.
  • Refactor subscription retrieval to use Optional and return a null-based DTO when no subscription exists.
  • Implement logout logic with Redis-based token blacklist and adjust billing/card DTO to return empty data when missing.
  • Extend CI workflow with Sentry and clock-in cron environment variables.

Reviewed Changes

Copilot reviewed 61 out of 61 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
batch/src/main/java/com/mangoboss/batch/auto_clock_out/domain/service/AutoClockOutService.java Update package and imports for auto clock-out service
app/src/main/java/com/mangoboss/app/infra/persistence/SubscriptionRepositoryImpl.java Change findByBossId to return Optional
app/src/main/java/com/mangoboss/app/infra/persistence/FaqRepositoryImpl.java Add FAQ repository implementation
app/src/main/java/com/mangoboss/app/dto/faq/FaqResponse.java Add record-based DTO for FAQ responses
app/src/main/java/com/mangoboss/app/domain/service/subscription/SubscriptionService.java Refactor subscription retrieval and null fallback logic
app/src/main/java/com/mangoboss/app/domain/service/faq/FaqService.java Add service to fetch FAQs by category
app/src/main/java/com/mangoboss/app/domain/service/billing/BillingService.java Modify billing info logic to return empty DTO when card data is missing
app/src/main/java/com/mangoboss/app/domain/service/auth/AuthService.java Implement logout/blacklist with Redis
app/src/main/java/com/mangoboss/app/domain/repository/SubscriptionRepository.java Update interface to return Optional
app/src/main/java/com/mangoboss/app/domain/repository/FaqRepository.java Add FAQ repository interface
app/src/main/java/com/mangoboss/app/common/util/JwtUtil.java Add method to calculate remaining refresh token expiration
app/src/main/java/com/mangoboss/app/common/exception/CustomErrorInfo.java Add errors for invalid refresh token and FAQ not found
app/src/main/java/com/mangoboss/app/api/facade/subscription/SubscriptionFacade.java Handle null subscription by returning empty response DTO
app/src/main/java/com/mangoboss/app/api/facade/faq/StaffFaqFacade.java Map staff FAQ entities to DTOs
app/src/main/java/com/mangoboss/app/api/facade/faq/BossFaqFacade.java Map boss FAQ entities to DTOs
app/src/main/java/com/mangoboss/app/api/facade/auth/AuthFacade.java Add blacklist validation and logout facade methods
app/src/main/java/com/mangoboss/app/api/controller/faq/StaffFaqController.java Add REST endpoint for staff FAQs
app/src/main/java/com/mangoboss/app/api/controller/faq/BossFaqController.java Add REST endpoint for boss FAQs
app/src/main/java/com/mangoboss/app/api/controller/auth/AuthController.java Consolidate imports and add logout endpoint
.github/workflows/cd-dev.yml Add Sentry DSN/auth and clock-in cron vars to CI env setup
Comments suppressed due to low confidence (2)

app/src/main/java/com/mangoboss/app/domain/service/subscription/SubscriptionService.java:34

  • Returning null here forces callers to handle null checks; consider returning Optional<SubscriptionEntity> from the service to make absence explicit in the API.
return subscriptionRepository.findByBossId(bossId).orElse(null);

app/src/main/java/com/mangoboss/app/domain/service/billing/BillingService.java:79

  • This single branch now treats missing billing and missing card data identically; consider distinguishing billing == null (not found) from missing card info to preserve error semantics or return an Optional response.
if (billing == null || billing.getBillingKey() == null || billing.getCardData() == null) {

@Simzard10 Simzard10 merged commit e7aac66 into main Jun 9, 2025
8 checks passed
@Simzard10 Simzard10 changed the title release: dev -> main [Release] 사장/알바생 FAQ 조회 API 개발, 로그아웃 기능 개발, 지각 시 사장에게 알림 기능 추가 Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd 배포 및 빌드 설정 feat 새로운 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants