Skip to content

Conversation

@urasakikeisuke
Copy link
Collaborator

Summary

This PR removes the temporary workaround introduced in v1.4.1/v1.4.2.
Since python-neo-lzf v0.3.5 now provides wheels for Linux aarch64, we no longer need to fall back to python-lzf.

Changes

  • Updated pyproject.toml:
    • Removed conditional dependency logic for sys_platform / platform_machine.
    • Removed python-lzf entirely.
    • Set requirement to python-neo-lzf>=0.3.5.

Impact

  • Linux ARM64 users: Will now use the python-neo-lzf wheels.
  • All other users: No change in behavior, just a version bump.

Versioning

This cleanup warrants a patch release (v1.4.3).

The upstream package `python-neo-lzf` v0.3.5 now provides pre-built wheels for Linux aarch64.
This commit:
- Bumps the dependency to `python-neo-lzf>=0.3.5`.
- Removes the conditional fallback to `python-lzf`.
- Cleans up `pyproject.toml` to use standard dependencies for all platforms.y

Signed-off-by: urasakikeisuke <keisuke.urasaki@map4.jp>
@urasakikeisuke urasakikeisuke self-assigned this Dec 26, 2025
@urasakikeisuke urasakikeisuke added rd/chore Updating grunt tasks etc; no production code change rd/patch labels Dec 26, 2025
Copy link

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

@github-actions
Copy link

github-actions bot commented Dec 26, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/pypcd4
   __init__.py20100% 
   _version.py18478%15–19
   pointcloud2.py591280%87–101
   pypcd4.py4244889%24–25, 136, 189, 352–353, 567, 583–605, 620–626, 636–646, 657–697, 707–708, 927–929, 949–950, 1071, 1076, 1079
TOTAL5036487% 

Tests Skipped Failures Errors Time
67 1 💤 0 ❌ 0 🔥 0.859s ⏱️

@urasakikeisuke urasakikeisuke merged commit 53a4eeb into main Jan 7, 2026
12 checks passed
@urasakikeisuke urasakikeisuke deleted the refactor/remove-python-neo-lzf-arm-workaround branch January 7, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rd/chore Updating grunt tasks etc; no production code change rd/patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants