Skip to content

Conversation

@jorben
Copy link
Collaborator

@jorben jorben commented Jan 26, 2026

Summary

This PR adds a comprehensive contributing guide and updates the AGENTS.md file.

Changes

New Files

  • CONTRIBUTING.md - Comprehensive contributing guide including:
    • How to add new features (step-by-step development workflow)
    • Testing guidelines
    • Code examples and best practices

Modified Files

  • AGENTS.md - Refactored to reference CONTRIBUTING.md for detailed feature development instructions
  • .gitignore - Updated with relevant patterns

Test Fixes

  • Preview.test.tsx - Fixed 6 failing tests:
    • Updated mockFailedTask to use correct status (PARTIAL_FAILED=8)
    • Added missing translation keys (preview.retry_failed, preview.retry_all, preview.more_actions, preview.image_load_failed)
    • Adjusted tests for dropdown menu button structure
    • Simplified pagination tests for JSDOM compatibility

Testing

  • npm run test:renderer - All 192 tests passing
  • npm run lint - No errors

- Update i18n mock to include new translation keys for retry and more actions
- Change mock failed task to use PARTIAL_FAILED status (8) instead of FAILED (0)
- Refactor tests to verify "More Actions" dropdown instead of individual action buttons
- Update test descriptions to reflect new UI structure with primary/dropdown actions
- Add verification for dropdown trigger elements in button tests

chore: add .codebuddy to .gitignore
Add detailed CONTRIBUTING.md file with:
- Code of conduct and community guidelines
- Complete development setup instructions
- Step-by-step feature development workflow
- Code style guidelines and naming conventions
- Commit message and PR process documentation
- Testing guidelines and help resources

Refactor AGENTS.md to remove duplicated feature development instructions
and reference the new CONTRIBUTING.md guide instead, improving documentation
organization and maintainability.
@jorben jorben merged commit c0ca7ec into master Jan 26, 2026
2 checks passed
@jorben jorben deleted the docs/contributing-guide branch January 27, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants