fix(deps): ⬆️ upgrade Electron to v38 and fix deprecated boolean package #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade electron from ^35.0.2 to ^38.0.0 - Add npm overrides for @electron/get@^4.0.2 and global-agent@^3.0.1 - This resolves the deprecated boolean@3.2.0 warning during npm install Co-Authored-By: Claude <noreply@anthropic.com>
- Change status check from `status < 2` to `status === -1 || status === 1` - FAILED tasks (status=0) can now be viewed for delete/retry actions - Update tests to match actual component UI behavior (dropdown menus) - Add missing i18n translation mocks in test file Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
^35.0.2to^38.0.0@electron/get@^4.0.2andglobal-agent@^3.0.1to resolve deprecatedboolean@3.2.0warningChanges
Dependency Updates (
package.json)electronto^38.0.0overridesconfiguration to force newer dependency versionsBug Fix (
Preview.tsx)status < 2tostatus === -1 || status === 1Test Updates (
Preview.test.tsx)Test Plan
npm install- no deprecatedbooleanwarningnpm ls boolean- package not in dependency treenpm run dev- app starts normallynpm run lint- passes (only pre-existing warning)npm run test:unit- 757 tests passnpm run test:renderer- 192 tests pass🤖 Generated with Claude Code