-
Notifications
You must be signed in to change notification settings - Fork 20
Implement tension hold during belt retraction and flexible state transitions #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Maslow-Main
Are you sure you want to change the base?
Conversation
Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>
Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>
Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>
|
Modify Requirements Summary 2 from: ✅ Allow moving between retract all and extend all with no errors if not all belts are extended or measurements don't match extended frame to Allow moving between retract all, extend all and release tension states with no errors if not all belts are extended or measurements don't match extended frame. |
|
Also allow moving between retract all, extend all and release tension states, with no errors if not all belts are extended or measurements don't match extended frame. |
|
@MaslowBot Re-write to also allow moving between retract all, extend all and release tension states, with no errors if not all belts are extended or measurements don't match extended frame. |
|
User @DaveCoulthurst mentioned @MaslowBot with the following request: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ @MaslowBot Re-write to also allow moving between retract all, extend all and release tension states, with no errors if not all belts are extended or measurements don't match extended frame. ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request. |
Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>
Done. Updated state transitions to allow moving freely between retract all, extend all, and release tension states without validation errors. Changes in commit 3ba2ba5:
|
Belt retraction now maintains tension for 10 seconds after detection to enable proper tension testing. State transitions between RETRACTING, EXTENDING, and RELEASE_TENSION are fully bidirectional to allow interrupting operations without errors.
Changes
Tension hold logic (
MotorUnit::pull_tight())tensionDetectedandtensionDetectedTimevariablesTENSION_HOLD_DURATION_MSfor maintainabilityFlexible state transitions (
Calibration::requestStateChange())Example behavior
Before:
After:
Users can now switch freely between retract all, extend all, and release tension operations at any time without validation errors, regardless of belt extension status or measurements.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.