This repository was archived by the owner on Jun 12, 2025. It is now read-only.
[iOS] Add workaround for using Moko in tests and previews #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-bat
reviewed
Oct 9, 2024
Contributor
tomas-bat
left a comment
tomas-bat
left a comment
There was a problem hiding this comment.
I tried to test iOS previews and I was getting some error related to our UIToolkit Bundle+Extensions.swift file..
It was probably some workaround which now causes crashes, but when I tried to use .module instead of this workaround, the previews started working 😅 So maybe the workaround is outdated or something..
This isn't really related to this PR, though.. So let me know if you want to look into it and fix it here, or if I should create a task for it..
tomas-bat
reviewed
Oct 11, 2024
ios/PresentationLayer/UIToolkit/Sources/UIToolkit/Extensions/BundleToken.swift
Show resolved
Hide resolved
tomas-bat
approved these changes
Oct 11, 2024
Contributor
|
Don't know why Github decided to close this 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
💡 What’s new?
😶 What’s missing?
📚 References