Fix invalid retraction for mz_roles #34843
Open
+75
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SangJunBak
force-pushed
the
jun/fix-mz-roles-invalid-retraction
branch
2 times, most recently
from
4246461 to
24d31b6
Compare
By having a system variable as an input to a addition/retraction, we were able to get in a state of getting invalid retractions by flipping the system variable. We circumvent this by removing the system variable from the equation. This should be okay since by default, the `login` and `superuser` attribute in Cloud should be null, effectively doing the same thing as the code before.
SangJunBak
force-pushed
the
jun/fix-mz-roles-invalid-retraction
branch
from
24d31b6 to
c6042c3
Compare
aljoscha
reviewed
Jan 28, 2026
| SELECT usename, usesysid, usecreatedb, usesuper, userepl, usebypassrls, passwd, valuntil, useconfig FROM pg_user; | ||
| ---- | ||
| materialize@foocorp.io 20190 false NULL false false NULL NULL NULL | ||
| mz_support 16662 false true false false NULL NULL NULL |
Contributor
There was a problem hiding this comment.
Might it become a problem that this now shows up here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having a system variable as an input to a addition/retraction, we were able to get in a state of getting invalid retractions by flipping the system variable. We circumvent this by removing the system variable from the equation.
This should be okay since by default, the
loginandsuperuserattribute in Cloud should be null, effectively doing the same thing as the code before.Motivation
fixes https://github.com/MaterializeInc/database-issues/issues/10042
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.