Skip to content

Conversation

@zstack-robot-2
Copy link
Collaborator

  1. Add runtimeParams field to APIExecuteGuestVmScriptMsg for dynamic parameter passing
  2. Add mergeRenderParams() method to merge script default params with runtime params
  3. Add validation for runtimeParams JSON format in GuestToolsApiInterceptor
  4. Add validation to ensure all script placeholders have corresponding params
  5. Store merged params in execution record for traceability
  6. Add unit tests for runtime params functionality

Resolves: ZSTAC-79185

Change-Id: I7377637968707664656b74727665746a6f7a6a65

sync from gitlab !8958

1. Add runtimeParams field to APIExecuteGuestVmScriptMsg for dynamic parameter passing
2. Add mergeRenderParams() method to merge script default params with runtime params
3. Add validation for runtimeParams JSON format in GuestToolsApiInterceptor
4. Add validation to ensure all script placeholders have corresponding params
5. Store merged params in execution record for traceability
6. Add unit tests for runtime params functionality

Resolves: ZSTAC-79185

Change-Id: I7377637968707664656b74727665746a6f7a6a65
@coderabbitai
Copy link

coderabbitai bot commented Dec 26, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • sdk/src/main/java/org/zstack/sdk/ExecuteGuestVmScriptAction.java is excluded by !sdk/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sync/lin.ma/ZSTAC-79185@@2

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants