Improved JavaScript for cookie-dealing with high-ppi devices. #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can use parameters on the image-src to recalculate the resolution of the image on different break-points. Debug-Mode writes image dimensions into the cached images. Prevent cache via config for development.
- setup image sizes for different breakpoints via a term and then image.jpg?size=term - cropping by ratio on every term - sharpen setup on every term
…itelist/blacklist concept.
…s into code comments and readme.textile.
…s – Better handling of crop ratios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I reported in #115, I see a problem in using screen.width alone as a source for doing the math, when it comes to high-ppi devices.
It seems I now figured out a highly reliabe way to detect the actual screen size of a display – meaning especially the high-ppi screens on mobiles like smartphones and tablets.
Have a look:
https://github.com/Darkwing371/Adaptive-Images-Uber-Extended/tree/ai-cookie-snippet.js
Read the readme, check code and comments and feel free to comment/contribute for improvements and suggestions!
And most of all: use it, if you think it’s a good idea! :)
Note: since this is my first pull request ever, I hope everything went ok with it so far … ;)