Introducing thread/microblog locking #1773
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentiGorlich
added
enhancement
BentiGorlich
force-pushed
the
new/lock-entries-and-posts
branch
from
ebba215 to
3234d80
Compare
Member
|
Is still a draft or not? |
Member
Author
|
Nope, ready to be reviewed :) |
BentiGorlich
force-pushed
the
new/lock-entries-and-posts
branch
from
71bc4bf to
c81f5ca
Compare
melroy89
reviewed
Nov 13, 2025
| $this->groupFactory->getActivityPubId($object->magazine), | ||
| $this->urlGenerator->generate('ap_user_followers', ['username' => $activity->userActor->username], UrlGeneratorInterface::ABSOLUTE_URL), | ||
| ], | ||
| 'object' => $objectUrl, |
Member
There was a problem hiding this comment.
Maybe still good to check if $objectUrl is no null/empty?
melroy89
reviewed
Nov 13, 2025
| $this->logger->info('[CreateHandler::doWork] Did not create the post, because the magazine {m} restricts posting to mods and {u} is not a mod', ['m' => $e->magazine, 'u' => $username]); | ||
| } catch (InstanceBannedException $e) { | ||
| $this->logger->info('[CreateHandler::doWork] Did not create the post, because the user\'s instance is banned'); | ||
| } catch (UserBlockedException $e) { |
Member
There was a problem hiding this comment.
Unrelated to your change, but I think $e can be removed here as well. Since its not used.
BentiGorlich
force-pushed
the
new/lock-entries-and-posts
branch
from
c81f5ca to
50c314a
Compare
Member
|
I notice you recently made (yesterday) some discoveries in this PR.. maybe its a good idea to wait with large PR after the 1.9.0 release..? Do you agree? |
Member
Author
|
I only resolved the merge conflict. But I don't need to have this in 1.9.0 |
- Threads and microblogs can now be locked so comments cannot be added anymore. This includes: - API support (new scopes) - ActivityPub support (`Lock` activity, post editing, etc.) - Authors and moderators can lock threads and microblogs - Add modlog items for the new lock and unlock events - Add tests for basically everything
- The `UpdateHandler` used the wrong boolean logic for setting the isLocked (which is the inverse of `commentsEnabled`) - Add write to `isLocked` during the creation of entries and posts via ActivityPub
BentiGorlich
force-pushed
the
new/lock-entries-and-posts
branch
from
8349166 to
01570d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lockactivity, post editing, etc.)Related to #248