Skip to content

Conversation

@razec3
Copy link

@razec3 razec3 commented Jan 19, 2026

Hi @McSnurtle

This PR solves #7 minimally.
In case of a curses.error, the drawing is erased and a warning message is shown.
Simple, but does the trick.
One has to try really hard to get an even smaller terminal for this not to work... A solution for that could be built separately.

Let me know if you'd like any changes
razec3

@McSnurtle McSnurtle self-requested a review January 19, 2026 18:16
Copy link
Owner

@McSnurtle McSnurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your minimal and working code. If this was written by an AI, then shame on you.

@McSnurtle
Copy link
Owner

I am unable to merge this because all commits must have verified signatures.

@razec3 razec3 force-pushed the feature/7-too-small-warning branch 4 times, most recently from b869717 to 4db7a79 Compare January 19, 2026 18:56
@razec3 razec3 force-pushed the feature/7-too-small-warning branch from 4db7a79 to 1d51c8b Compare January 19, 2026 19:34
@razec3
Copy link
Author

razec3 commented Jan 19, 2026

I'm honored you suspect my minimal changes to be AI, @McSnurtle .
Solved the verification issue.

Thanks for allowing me to contribute. I'm coming back to coding from a long break, and need some practice. If you continue opening "easy" issues, I'll be happy to take them whenever I have some time.

@razec3
Copy link
Author

razec3 commented Jan 19, 2026

I didn't use AI for my changes, but I did use it when pip install -e . didn't go my way and I couldn't figure out why.
Usually, I would create an issue to document it, but since it was discovered by AI, I don't know if you'd like it in your repo. Let me know.

I also found another minimal thing, this one without AI: the environment creation should enforce python < 3.14. art's latest version supports up to python 3.13. If you don't mind outside interference, I'll create an issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants