Handle compose down with container_name case #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lepus
approved these changes
Jan 5, 2026
Mcrich23
requested changes
Jan 5, 2026
Owner
Mcrich23
left a comment
Mcrich23
left a comment
There was a problem hiding this comment.
This looks great! Thank you
Would it be possible to add a new dynamic test for this? You can just make a new file in Tests/Container-Compose-DynamicTests called ComposeDownTests.swift. It could probably just bring up a container and then shut it down and make sure that everything goes up and down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use container_name: with a custom name in your compose file, compose up properly handles that, but compose down does not, and defaults to its internal naming, will fail to stop the container, and will not throw an error, because it eats the error.
See #38
This should resolve that case. PR contributed to with Claude.