Symbian port #2
Open
Symbian port #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GUI, keyboard, sound all work; keyboard is almost completely unresponsive when sound is playing though.
- use dirent.h instead of sys/dir.h - use anonymous, unshared semaphores If I understand the code right, these should be independent both between UnixSysSemaphore instances and between processes. Anyway, named semaphores aren't present on S60.
Presumably not initialised on the platform. Need to fix.
Otherwise makesis bombs with a verification error.
Somewhat more consistent with the S60 standard. Note that the .pkg file at this point expects to find the `lgpt10k` demo song directory in 'projects' at build time (this is very useful for testing).
Currently: a) crashes on exit, and b) doesn't appear to improve audio latency - still around 300ms on my test phone. Does not suffer from the UI trouble that the SDL one does.
Owner
|
Hey man. Cheers 2015-08-19 5:11 GMT+02:00 James Laird-Wah notifications@github.com:
|
Author
|
Wow, congratulations! All the best then (:
|
Still has some bleed around the edge but at least it's not horrible.
Depending on the driver, there is little or no control about the output buffer size. This adds up to several hundred milliseconds on my test phone (Nokia E63). This patch adds a delay before submitting samples for playing. If the system's output counter is too far behind the submitted samples, it waits until it isn't. This allows some measure of control over the invisible buffers. Of course, this introduces a magic value for the lag tolerance. Setting it too low causes glitches. These tend to be evenly periodic - so maybe rejigging things to submit (say) precisely 256 samples a throw would allow pushing this further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So... I think this is somewhere between 5 and 10 years too late. But here it is anyway.
This is a port in progress to Symbian S60-based devices; specifically S60v3 (not to be confused with Symbian^3). I doubt you'll ever want to merge it, but it's here as a pointer for any crazy person who might actually want to use it. (I personally just went back to a Nokia E63 after a succession of Android phones, but I don't think that's a popular choice.) With the appropriate SDK and tools it should work on any S60v3 and maybe even v5 device.
The GUI, input and sound all work at this point. Playing sound makes input unresponsive - I think the player thread ends up spinning where it should be yielding.
Anyway, thanks for building such a neat tool, and thank you also for open sourcing it! It's a pleasure to work with such a tidy codebase. I have to say, when I saw you play in Melbourne some five years ago I never thought I'd be pigging out on the phone that was in my pocket that day...