[Android] Improved performance + Batch schedule #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavantix
force-pushed
the
10.0.0-medapp
branch
from
9a2917f to
1125603
Compare
JeroenvdV
force-pushed
the
10.0.0-medapp
branch
2 times, most recently
from
f546ad0 to
251114b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance by greatly reducing the amount of JSON parsing and encoding needed to do the scheduling and removing of notifications. It does so by not saving one large JSON string in Shared Preferences, but adding a separate String key for each notification ID.
It further improves performance and usability by exposing new functionality to flutter: the ability to schedule multiple notifications at once (optionally replacing any existing ones).