Skip to content

Conversation

@jd
Copy link
Member

@jd jd commented Jan 13, 2026

This fixes a few new issues spotted by ruff. That's it!

Change-Id: I3ce2c054209f04fcc201122c22fd244b1840dc7c
Copilot AI review requested due to automatic review settings January 13, 2026 18:31
@mergify mergify bot deployed to Mergify Merge Protections January 13, 2026 18:31 Active
@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2026

🧪 CI Insights

Here's what we observed from your CI run for 9a8884e.

🟢 All jobs passed!

But CI Insights is watching 👀

@mergify mergify bot requested a review from a team January 13, 2026 18:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ruff linting tool from version 0.14.9 to 0.14.11 and includes code improvements that align with ruff's recommendations.

Changes:

  • Updated ruff dependency from 0.14.9 to 0.14.11
  • Refactored file I/O operations to use simpler Path.write_text() and Path.read_text() methods
  • Improved exception handling by adding proper exception chaining
  • Reorganized module structure by extracting global variables into a dedicated _globals.py module

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
uv.lock Updated ruff package version, hashes, and wheel URLs from 0.14.9 to 0.14.11
pyproject.toml Updated ruff dependency specification from 0.14.9 to 0.14.11
mergify_cli/ci/scopes/cli.py Simplified file I/O operations and added exception chaining
mergify_cli/_globals.py New module containing extracted global variables (console and VERSION)
mergify_cli/init.py Refactored to re-export console and VERSION from _globals module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergify
Copy link
Contributor

mergify bot commented Jan 14, 2026

Merge Queue Status

✅ The pull request has been merged at 9a8884e

This pull request spent 1 minute 44 seconds in the queue, including 1 minute 31 seconds running CI.
The checks were run on draft #911.

Required conditions to merge

@mergify mergify bot added the queued label Jan 14, 2026
mergify bot added a commit that referenced this pull request Jan 14, 2026
@mergify mergify bot merged commit 95600ce into main Jan 14, 2026
16 checks passed
@mergify mergify bot deleted the devs/jd/upgrade-ruff/I3ce2c054209f04fcc201122c22fd244b1840dc7c branch January 14, 2026 10:16
@mergify mergify bot removed the queued label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants