Skip to content

chore(deps): update mypy to 1.19.1 and fix type ignore comments #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Jan 14, 2026
Merged

chore(deps): update mypy to 1.19.1 and fix type ignore comments #906

mergify merged 1 commit into from
Jan 14, 2026
+65 −23

Conversation

@jd
Copy link
Member

@jd jd commented Jan 13, 2026

Updated mypy from 1.18.2 to 1.19.1. Changed type: ignore[misc] to
type: ignore[untyped-decorator] to match the actual error code.

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

@jd @claude
chore(deps): update mypy to 1.19.1 and fix type ignore comments
e15c71a 
Updated mypy from 1.18.2 to 1.19.1. Changed `type: ignore[misc]` to
`type: ignore[untyped-decorator]` to match the actual error code.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change-Id: I4db5a2604fc5a034a23acd8318193d272549151e
Copilot AI review requested due to automatic review settings January 13, 2026 19:00
@mergify mergify bot deployed to Mergify Merge Protections January 13, 2026 19:00 Active
@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2026 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2026 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for e15c71a.

🟢 All jobs passed!

But CI Insights is watching 👀

@mergify mergify bot requested a review from a team January 13, 2026 19:01
Copilot AI reviewed Jan 13, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the mypy type checker from version 1.18.2 to 1.19.1 and corrects type ignore comments to use the more specific untyped-decorator error code instead of the generic misc code. The update also introduces a new dependency (librt) which is required by mypy 1.19.1.

Changes:

  • Updated mypy from 1.18.2 to 1.19.1 in both pyproject.toml and uv.lock
  • Changed type: ignore[misc] to type: ignore[untyped-decorator] in decorator functions
  • Added librt 0.7.7 as a new transitive dependency of mypy

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
uv.lock Updated mypy package metadata to version 1.19.1 and added librt dependency
pyproject.toml Updated mypy version specifier from 1.18.2 to 1.19.1
mergify_cli/stack/cli.py Changed type ignore comments to use specific untyped-decorator error code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mergify bot added a commit that referenced this pull request Jan 14, 2026
@mergify
Merge of #906
3a3f821
@mergify
Copy link
Contributor

mergify bot commented Jan 14, 2026 •
edited
Loading

Merge Queue Status

✅ The pull request has been merged at e15c71a

This pull request spent 1 minute 40 seconds in the queue, including 1 minute 24 seconds running CI.
The checks were run on draft #909.

Required conditions to merge

@mergify mergify bot added the queued label Jan 14, 2026
@mergify mergify bot mentioned this pull request Jan 14, 2026
Closed
36 tasks
@mergify mergify bot merged commit 504fb53 into main Jan 14, 2026
16 checks passed
@mergify mergify bot deleted the devs/jd/mypy/I4db5a2604fc5a034a23acd8318193d272549151e branch January 14, 2026 08:21
@mergify mergify bot removed the queued label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Greesb Greesb Greesb approved these changes

@remyduthu remyduthu remyduthu approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jd @Greesb @remyduthu