-
Notifications
You must be signed in to change notification settings - Fork 17
SIP-28: Background Events #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| --- | ||
| sip: 28 | ||
| title: Background Events | ||
| status: Draft | ||
| author: Olaf Tomalka (@ritave) | ||
| created: 2024-10-09 | ||
| --- | ||
|
|
||
| ## Abstract | ||
|
|
||
| This SIP introduces a way to schedule non-recurring events in the future. | ||
|
|
||
| ## Motivation | ||
|
|
||
| Scheduled recurring events are already supported in the Snaps platform via the Cronjobs feature. By introducing non-recurring events we will allow novel use-cases for Snap developers, such as allowing a snap that sets a reminder for ENS domain expiration date. | ||
|
|
||
| ## Specification | ||
|
|
||
| > Indented sections like this are considered non-normative. | ||
|
|
||
| ### Language | ||
|
|
||
| The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", | ||
| "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and | ||
| "OPTIONAL" written in uppercase in this document are to be interpreted as described in [RFC 2119](https://www.ietf.org/rfc/rfc2119.txt) | ||
|
|
||
| ### Snap Manifest | ||
|
|
||
| This SIP doesn't introduce any new permissions, but rather extends `endowment:cronjob` with new capabilities through two new RPC methods. | ||
|
|
||
| ### RPC Methods | ||
|
|
||
| #### `snap_scheduleBackgroundEvent` | ||
|
|
||
| This method allows a Snap to schedule a one-off callback to `onCronjob` handler in the future with a JSON-RPC request object as a parameter. | ||
|
|
||
| ```typescript | ||
| type ScheduleBackgroundEventParams = { | ||
| date: string; | ||
| request: JsonRpcRequest; | ||
| }; | ||
|
|
||
| type ScheduleBackgroundEventResult = string; | ||
| ``` | ||
|
|
||
| The RPC method takes two parameters: | ||
|
|
||
| - `date` - An [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601) date and time and optional timezone offset. | ||
ritave marked this conversation as resolved.
Show resolved
Hide resolved
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is Wondering what is the simplest for developers.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| - The time's precision SHALL be truncated on the extension side to minutes. | ||
| - If no timezone is provided, the time SHALL be understood to be local-time. | ||
| > Use ISO's `Z` identifier if you want to use UTC time. | ||
| - `request` - A JSON object that will provided as-is to `onCronjob` handler as parameter. | ||
|
|
||
| An example of usage is given below. | ||
|
|
||
| ```typescript | ||
| snap.request({ | ||
| method: "snap_scheduleBackgroundEvent", | ||
| params: { | ||
| date: "2024-10-09T09:59", | ||
| request: { | ||
| method: "foobar", | ||
| params: { | ||
| foo: "bar", | ||
| }, | ||
| }, | ||
| }, | ||
| }); | ||
| ``` | ||
|
|
||
| The RPC method call returns a `string` that is a unique ID representing that specific background event, allowing it to be cancelled. | ||
|
|
||
| #### `snap_cancelBackgroundEvent` | ||
ritave marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| This method allows to cancel an already scheduled background event using the unique ID returned from `snap_backgroundEventSchedule` | ||
|
|
||
| ```typescript | ||
| type CancelBackgroundEventParams = { id: string }; | ||
| ``` | ||
|
|
||
| This RPC method takes one argument: | ||
|
|
||
| - `id` - The id that was returned during schedule. | ||
|
|
||
| An example of usage is given below. | ||
|
|
||
| ```typescript | ||
| snap.request({ | ||
| method: "snap_cancelBackgroundEvent", | ||
| params: { | ||
| id: myReturnedId, | ||
| }, | ||
| }); | ||
| ``` | ||
|
|
||
| ### `onCronjob` handler | ||
|
|
||
| This SIP doesn't modify `onCronjob` handler in any way. | ||
|
|
||
| ## Copyright | ||
|
|
||
| Copyright and related rights waived via [CC0](../LICENSE). | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.