Skip to content

Conversation

@dawnseeker8
Copy link
Contributor

@dawnseeker8 dawnseeker8 commented Mar 19, 2025

This PR will fix the ledger sign transaction issue due to this ethereumjs upgrade PR #209

and basically the ethereumjs upgrade code change make the transaction rawTxHex contain 0x prefix which is not valid for to @ledgerhq/hw-eth-app clearSignTransaction function. that functions expect a rawTxHex without 0x prefix.

…nTransaction which cause ledger library break.
@dawnseeker8 dawnseeker8 requested a review from a team as a code owner March 19, 2025 10:17
@dawnseeker8 dawnseeker8 changed the title fix: fix: fix the ledger sign transaction issue due to this ethereumjs upgrade PR Mar 19, 2025
@dawnseeker8
Copy link
Contributor Author

@metamaskbot publish-preview

@dawnseeker8 dawnseeker8 added the team-accounts This should be handled by the Accounts Team label Mar 19, 2025
@github-actions
Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "17.2.1-9d37a15",
  "@metamask-previews/eth-hd-keyring": "12.1.0-9d37a15",
  "@metamask-previews/eth-ledger-bridge-keyring": "10.0.0-9d37a15",
  "@metamask-previews/eth-simple-keyring": "10.0.0-9d37a15",
  "@metamask-previews/eth-trezor-keyring": "8.0.0-9d37a15",
  "@metamask-previews/keyring-internal-api": "6.0.0-9d37a15",
  "@metamask-previews/keyring-internal-snap-client": "4.0.1-9d37a15",
  "@metamask-previews/eth-snap-keyring": "12.0.0-9d37a15",
  "@metamask-previews/keyring-snap-client": "4.0.1-9d37a15",
  "@metamask-previews/keyring-snap-sdk": "3.1.0-9d37a15",
  "@metamask-previews/keyring-utils": "3.0.0-9d37a15"
}

@ccharly ccharly changed the title fix: fix the ledger sign transaction issue due to this ethereumjs upgrade PR fix(keyring-eth-ledger-bridge): trim 0x prefix for sign transaction (due to latest @ethereumjs upgrade) Mar 21, 2025
@ccharly ccharly changed the title fix(keyring-eth-ledger-bridge): trim 0x prefix for sign transaction (due to latest @ethereumjs upgrade) fix(keyring-eth-ledger-bridge): trim 0x prefix for signTransaction (due to latest @ethereumjs upgrade) Mar 21, 2025
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I haven't tested it myself though.

@dawnseeker8 dawnseeker8 added this pull request to the merge queue Mar 21, 2025
Merged via the queue into main with commit 8ae37c9 Mar 21, 2025
35 of 36 checks passed
@dawnseeker8 dawnseeker8 deleted the fix/ledger-sign-transaction-broken-after-ethereumjs-upgrade branch March 21, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-accounts This should be handled by the Accounts Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants