generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add TrezorKeyringV2 (and OneKeyKeyringV2)
#412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mathieuartu
wants to merge
11
commits into
main
Choose a base branch
from
feat/trezor-keyring-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0beaae5 to
5dfac85
Compare
5dfac85 to
9d07ffc
Compare
gantunesr
reviewed
Jan 7, 2026
gantunesr
previously approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://consensyssoftware.atlassian.net/browse/MUL-1321
Examples
Note
Adds unified V2 adapters for hardware keyrings.
TrezorKeyringV2andOneKeyKeyringV2(extendsEthKeyringWrapper) expose legacy keyrings viaKeyringV2andKeyringAccountbip44:derive-indexandbip44:derive-path(BIP-44, legacy MEW, SLIP0044 testnet) with entropy-source validation and HD-path switching that clears registrygetAccountscachesKeyringAccounts and handles locked devices (returns cache or throws), customdeserializeavoids device access until unlocked;deleteAccountimplementedtrezor-keyring: makeaddressFromIndexprotected; addgetIndexForAddress; update call sitesindex.ts; add extensive tests; raise coverage thresholds and wire package/tsconfig deps; README dependency graph updatedWritten by Cursor Bugbot for commit 92a41fa. This will update automatically on new commits. Configure here.